Fix permissions for Token DELETE endpoint to match GET and POST (#27610)#28099
Merged
lunny merged 1 commit intogo-gitea:release/v1.21from Nov 17, 2023
Merged
Fix permissions for Token DELETE endpoint to match GET and POST (#27610)#28099lunny merged 1 commit intogo-gitea:release/v1.21from
lunny merged 1 commit intogo-gitea:release/v1.21from
Conversation
…itea#27610) Fixes go-gitea#27598 In go-gitea#27080, the logic for the tokens endpoints were updated to allow admins to create and view tokens in other accounts. However, the same functionality was not added to the DELETE endpoint. This PR makes the DELETE endpoint function the same as the other token endpoints and adds unit tests
GiteaBot
added
the
lgtm/need 2
nanguanlin6
approved these changes
Nov 17, 2023
GiteaBot
added
lgtm/need 1
CaiCandong
approved these changes
Nov 17, 2023
GiteaBot
added
lgtm/done
lunny
approved these changes
Nov 17, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27610 by @evantobin
Fixes #27598
In #27080, the logic for the tokens endpoints were updated to allow admins to create and view tokens in other accounts. However, the same functionality was not added to the DELETE endpoint. This PR makes the DELETE endpoint function the same as the other token endpoints and adds unit tests